Fix click on <Datagrid> Select All button bubbles up to parent Datagrid
#9567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This approach is too much, especially since it means to support a feature (nested datagrids) that we don't want to support. |
|
Well, all the other inputs stop propagation, so move to the checkbox instead (as mentioned in the description)? |
|
Yes, the checkbox can stop propagation |
|
Moved to Select all checkbox. |
fzaninotto
approved these changes
Jan 11, 2024
fzaninotto
changed the title
<Datagrid> Select All button bubbles up to parent Datagrid
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds stopPropagation() to the entire DataGrid, to avoid propagation when clicking anywhere in the grid.
Currently, clicking the select all checkbox or an empty space on the header still triggers the click on the parent element (e.g. nest 2 DataGrids and the select all button will trigger the rowClick of the parent DataGrid).
If this approach seems too much, then we could move this line to the checkbox in DataGridHeader.